Drezil/imgui
1
0
Fork 0
mirror of https://github.com/Drezil/imgui.git synced 2024-11-15 01:17:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Internals: SetShortcutRouting() move code so next commit is easier to read. Should be no-op.

Browse Source
This commit is contained in:
ocornut 2024-01-24 17:47:30 +01:00
parent 1509842107
commit 9176eedf24
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
imgui.cpp
View File

@ -8438,17 +8438,20 @@ bool ImGui::SetShortcutRouting(ImGuiKeyChord key_chord, ImGuiID owner_id, ImGuiI
return true; return true;
} }
// Specific culling for shortcuts with no modifiers when there's an active id. // Specific culling when there's an active.
// e.g. Shortcut(ImGuiKey_G) also generates 'g' character, should not trigger when InputText() is active. if (g.ActiveId != 0 && g.ActiveId != owner_id)
// but Shortcut(Ctrl+G) should generally trigger when InputText() is active. {
// TL;DR: lettered shortcut with no mods or with only Alt mod will not trigger while an item reading text input is active. // Cull shortcuts with no modifiers when it could generate a character.
// (We cannot filter based on io.InputQueueCharacters[] contents because of trickling and key<>chars submission order are undefined) // e.g. Shortcut(ImGuiKey_G) also generates 'g' character, should not trigger when InputText() is active.
if ((flags & ImGuiInputFlags_RouteFocused) && (g.ActiveId != 0 && g.ActiveId != owner_id)) // but Shortcut(Ctrl+G) should generally trigger when InputText() is active.
if (g.IO.WantTextInput && IsKeyChordPotentiallyCharInput(key_chord)) // TL;DR: lettered shortcut with no mods or with only Alt mod will not trigger while an item reading text input is active.
// (We cannot filter based on io.InputQueueCharacters[] contents because of trickling and key<>chars submission order are undefined)
if ((flags & ImGuiInputFlags_RouteFocused) && g.IO.WantTextInput && IsKeyChordPotentiallyCharInput(key_chord))
{ {
IMGUI_DEBUG_LOG_INPUTROUTING("SetShortcutRouting(%s, owner_id=0x%08X, flags=%04X) -> filtered as potential char input\n", GetKeyChordName(key_chord), owner_id, flags); IMGUI_DEBUG_LOG_INPUTROUTING("SetShortcutRouting(%s, owner_id=0x%08X, flags=%04X) -> filtered as potential char input\n", GetKeyChordName(key_chord), owner_id, flags);
return false; return false;
} }
}
// FIXME-SHORTCUT: A way to configure the location/focus-scope to test would render this more flexible. // FIXME-SHORTCUT: A way to configure the location/focus-scope to test would render this more flexible.
const int score = CalcRoutingScore(g.CurrentFocusScopeId, owner_id, flags); const int score = CalcRoutingScore(g.CurrentFocusScopeId, owner_id, flags);