Nav: Fixed SetItemDefaultFocus() from not scrolling when item is partially visible. (#2814, #2812)

This commit is contained in:
domgho 2019-09-29 12:29:48 +02:00 committed by ocornut
parent bb224c8aa1
commit 6ca1556d02
2 changed files with 3 additions and 1 deletions

View File

@ -64,6 +64,8 @@ Other changes:
- Nav: Fixed an issue with Gamepad navigation when the movement lead to a scroll and - Nav: Fixed an issue with Gamepad navigation when the movement lead to a scroll and
frame time > repeat rate. Triggering a new move request on the same frame as a move frame time > repeat rate. Triggering a new move request on the same frame as a move
result lead to an incorrect calculation and loss of navigation id. (#6171) result lead to an incorrect calculation and loss of navigation id. (#6171)
- Nav: Fixed SetItemDefaultFocus() from not scrolling when item is partially visible.
(#2814, #2812) [@DomGries]
- IO: Lifted constraint to call io.AddEventXXX functions from current context. (#4921, #5856, #6199) - IO: Lifted constraint to call io.AddEventXXX functions from current context. (#4921, #5856, #6199)
- InputText: Fixed not being able to use CTRL+Tab while an InputText() using Tab - InputText: Fixed not being able to use CTRL+Tab while an InputText() using Tab
for completion or textinput is active (regresion from 1.89). for completion or textinput is active (regresion from 1.89).

View File

@ -7505,7 +7505,7 @@ void ImGui::SetItemDefaultFocus()
NavUpdateAnyRequestFlag(); NavUpdateAnyRequestFlag();
// Scroll could be done in NavInitRequestApplyResult() via an opt-in flag (we however don't want regular init requests to scroll) // Scroll could be done in NavInitRequestApplyResult() via an opt-in flag (we however don't want regular init requests to scroll)
if (!IsItemVisible()) if (!window->ClipRect.Contains(g.LastItemData.Rect))
ScrollToRectEx(window, g.LastItemData.Rect, ImGuiScrollFlags_None); ScrollToRectEx(window, g.LastItemData.Rect, ImGuiScrollFlags_None);
} }