mirror of
				https://github.com/Drezil/imgui.git
				synced 2025-11-04 07:01:04 +01:00 
			
		
		
		
	Turned ImVec2 to const ref to RenderChar(), RenderText(), ColorButton(), PushClipRect(). for consistency. Comments about polygon filling winding order.
This commit is contained in:
		@@ -5454,7 +5454,7 @@ bool ImGui::ColorPicker4(const char* label, float col[4], ImGuiColorEditFlags fl
 | 
			
		||||
// FIXME: May want to display/ignore the alpha component in the color display? Yet show it in the tooltip.
 | 
			
		||||
// 'desc_id' is not called 'label' because we don't display it next to the button, but only in the tooltip.
 | 
			
		||||
// Note that 'col' may be encoded in HSV if ImGuiColorEditFlags_InputHSV is set.
 | 
			
		||||
bool ImGui::ColorButton(const char* desc_id, const ImVec4& col, ImGuiColorEditFlags flags, ImVec2 size)
 | 
			
		||||
bool ImGui::ColorButton(const char* desc_id, const ImVec4& col, ImGuiColorEditFlags flags, const ImVec2& size_arg)
 | 
			
		||||
{
 | 
			
		||||
    ImGuiWindow* window = GetCurrentWindow();
 | 
			
		||||
    if (window->SkipItems)
 | 
			
		||||
@@ -5462,11 +5462,8 @@ bool ImGui::ColorButton(const char* desc_id, const ImVec4& col, ImGuiColorEditFl
 | 
			
		||||
 | 
			
		||||
    ImGuiContext& g = *GImGui;
 | 
			
		||||
    const ImGuiID id = window->GetID(desc_id);
 | 
			
		||||
    float default_size = GetFrameHeight();
 | 
			
		||||
    if (size.x == 0.0f)
 | 
			
		||||
        size.x = default_size;
 | 
			
		||||
    if (size.y == 0.0f)
 | 
			
		||||
        size.y = default_size;
 | 
			
		||||
    const float default_size = GetFrameHeight();
 | 
			
		||||
    const ImVec2 size(size_arg.x == 0.0f ? default_size : size_arg.x, size_arg.y == 0.0f ? default_size : size_arg.y);
 | 
			
		||||
    const ImRect bb(window->DC.CursorPos, window->DC.CursorPos + size);
 | 
			
		||||
    ItemSize(bb, (size.y >= default_size) ? g.Style.FramePadding.y : 0.0f);
 | 
			
		||||
    if (!ItemAdd(bb, id))
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user